Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] JDK matrix Buildkite pipelines (pt 2/Windows) #15563

Merged
merged 4 commits into from
Nov 10, 2023

Conversation

dliappis
Copy link
Contributor

@dliappis dliappis commented Nov 10, 2023

Release notes

[rn:skip]

What does this PR do?

This commit adds JDK matrix Buildkite pipelines for Windows 2022, 2019 and 2016.

It also makes the groups easier to read (on both Linux and Windows pipelines) by removing the os-jdk prefix from the job labels.

testDLQWriterFlusherRemovesExpiredSegmentWhenCurrentHeadSegmentIsEmpty fails on Windows Buildkite agents and it's a test issue tracked in #15562.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works:

Linux improved group views (link):

Screenshot

image

image

Windows run (link):

This run demonstrates two failures (Windows 2022 + 2019) due to #15562 , as well a success (Windows 2019).

Screenshot

image

Note that we also collect archived build artifacts to assist with troubleshooting:

Screenshot

image

How to test this PR locally

Just kick off a build using https://buildkite.com/elastic/logstash-windows-jdk-matrix-pipeline#new and defining this PR i.e. pull/15563/merge in the branch field.

Related issues

This commit adds JDK matrix Buildkite pipelines for
Windows 2022, 2019 and 2016.

It also makes the groups easier to read (on both Linux and Windows
pipelines) by removing the os-jdk prefix from the job labels.

`testDLQWriterFlusherRemovesExpiredSegmentWhenCurrentHeadSegmentIsEmpty`
fails on Windows Buildkite agents and it's a test issue tracked in
elastic#15562.

Relates:

- elastic#15539
- elastic/ingest-dev#1725
-
@dliappis dliappis added the ci label Nov 10, 2023
@dliappis dliappis requested a review from roaksoax November 10, 2023 12:40
@dliappis dliappis self-assigned this Nov 10, 2023
Copy link
Contributor

@roaksoax roaksoax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just one nit inline.

self.unit_tests,
]

def unit_tests(self) -> JobRetValues:
step_name_human = "Java Unit Test"
test_command = "# TODO"
step_name_human = "Unit Test"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only neat here is to maybe do "Unit Tests (Java/Ruby)"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea. Added it in 491fed5

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

raised #15566 to track the improvement

Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @dliappis

@dliappis dliappis merged commit 0ede19a into elastic:main Nov 10, 2023
5 checks passed
@dliappis
Copy link
Contributor Author

@logstashmachine backport 8.11

@dliappis
Copy link
Contributor Author

@logstashmachine backport 8.10

@dliappis
Copy link
Contributor Author

@logstashmachine backport 7.17

github-actions bot pushed a commit that referenced this pull request Nov 10, 2023
This commit adds JDK matrix Buildkite pipelines for
Windows 2022, 2019 and 2016.

It also makes the groups easier to read (on both Linux and Windows
pipelines) by removing the os-jdk prefix from the job labels.

`testDLQWriterFlusherRemovesExpiredSegmentWhenCurrentHeadSegmentIsEmpty`
fails on Windows Buildkite agents and it's a test issue tracked in
#15562.

Relates:

- #15539
- elastic/ingest-dev#1725

(cherry picked from commit 0ede19a)
github-actions bot pushed a commit that referenced this pull request Nov 10, 2023
This commit adds JDK matrix Buildkite pipelines for
Windows 2022, 2019 and 2016.

It also makes the groups easier to read (on both Linux and Windows
pipelines) by removing the os-jdk prefix from the job labels.

`testDLQWriterFlusherRemovesExpiredSegmentWhenCurrentHeadSegmentIsEmpty`
fails on Windows Buildkite agents and it's a test issue tracked in
#15562.

Relates:

- #15539
- elastic/ingest-dev#1725

(cherry picked from commit 0ede19a)
github-actions bot pushed a commit that referenced this pull request Nov 10, 2023
This commit adds JDK matrix Buildkite pipelines for
Windows 2022, 2019 and 2016.

It also makes the groups easier to read (on both Linux and Windows
pipelines) by removing the os-jdk prefix from the job labels.

`testDLQWriterFlusherRemovesExpiredSegmentWhenCurrentHeadSegmentIsEmpty`
fails on Windows Buildkite agents and it's a test issue tracked in
#15562.

Relates:

- #15539
- elastic/ingest-dev#1725

(cherry picked from commit 0ede19a)
dliappis added a commit that referenced this pull request Nov 13, 2023
This commit adds JDK matrix Buildkite pipelines for
Windows 2022, 2019 and 2016.

It also makes the groups easier to read (on both Linux and Windows
pipelines) by removing the os-jdk prefix from the job labels.

`testDLQWriterFlusherRemovesExpiredSegmentWhenCurrentHeadSegmentIsEmpty`
fails on Windows Buildkite agents and it's a test issue tracked in
#15562.

Relates:

- #15539
- elastic/ingest-dev#1725

(cherry picked from commit 0ede19a)

Co-authored-by: Dimitrios Liappis <[email protected]>
dliappis added a commit that referenced this pull request Nov 13, 2023
This commit adds JDK matrix Buildkite pipelines for
Windows 2022, 2019 and 2016.

It also makes the groups easier to read (on both Linux and Windows
pipelines) by removing the os-jdk prefix from the job labels.

`testDLQWriterFlusherRemovesExpiredSegmentWhenCurrentHeadSegmentIsEmpty`
fails on Windows Buildkite agents and it's a test issue tracked in
#15562.

Relates:

- #15539
- elastic/ingest-dev#1725

(cherry picked from commit 0ede19a)

Co-authored-by: Dimitrios Liappis <[email protected]>
dliappis added a commit that referenced this pull request Nov 13, 2023
This commit adds JDK matrix Buildkite pipelines for
Windows 2022, 2019 and 2016.

It also makes the groups easier to read (on both Linux and Windows
pipelines) by removing the os-jdk prefix from the job labels.

`testDLQWriterFlusherRemovesExpiredSegmentWhenCurrentHeadSegmentIsEmpty`
fails on Windows Buildkite agents and it's a test issue tracked in
#15562.

Relates:

- #15539
- elastic/ingest-dev#1725

(cherry picked from commit 0ede19a)

Co-authored-by: Dimitrios Liappis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants