-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] JDK matrix Buildkite pipelines (pt 2/Windows) #15563
Conversation
This commit adds JDK matrix Buildkite pipelines for Windows 2022, 2019 and 2016. It also makes the groups easier to read (on both Linux and Windows pipelines) by removing the os-jdk prefix from the job labels. `testDLQWriterFlusherRemovesExpiredSegmentWhenCurrentHeadSegmentIsEmpty` fails on Windows Buildkite agents and it's a test issue tracked in elastic#15562. Relates: - elastic#15539 - elastic/ingest-dev#1725 -
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! just one nit inline.
self.unit_tests, | ||
] | ||
|
||
def unit_tests(self) -> JobRetValues: | ||
step_name_human = "Java Unit Test" | ||
test_command = "# TODO" | ||
step_name_human = "Unit Test" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only neat here is to maybe do "Unit Tests (Java/Ruby)"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea. Added it in 491fed5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
raised #15566 to track the improvement
SonarQube Quality Gate |
💚 Build Succeeded
History
cc @dliappis |
@logstashmachine backport 8.11 |
@logstashmachine backport 8.10 |
@logstashmachine backport 7.17 |
This commit adds JDK matrix Buildkite pipelines for Windows 2022, 2019 and 2016. It also makes the groups easier to read (on both Linux and Windows pipelines) by removing the os-jdk prefix from the job labels. `testDLQWriterFlusherRemovesExpiredSegmentWhenCurrentHeadSegmentIsEmpty` fails on Windows Buildkite agents and it's a test issue tracked in #15562. Relates: - #15539 - elastic/ingest-dev#1725 (cherry picked from commit 0ede19a)
This commit adds JDK matrix Buildkite pipelines for Windows 2022, 2019 and 2016. It also makes the groups easier to read (on both Linux and Windows pipelines) by removing the os-jdk prefix from the job labels. `testDLQWriterFlusherRemovesExpiredSegmentWhenCurrentHeadSegmentIsEmpty` fails on Windows Buildkite agents and it's a test issue tracked in #15562. Relates: - #15539 - elastic/ingest-dev#1725 (cherry picked from commit 0ede19a)
This commit adds JDK matrix Buildkite pipelines for Windows 2022, 2019 and 2016. It also makes the groups easier to read (on both Linux and Windows pipelines) by removing the os-jdk prefix from the job labels. `testDLQWriterFlusherRemovesExpiredSegmentWhenCurrentHeadSegmentIsEmpty` fails on Windows Buildkite agents and it's a test issue tracked in #15562. Relates: - #15539 - elastic/ingest-dev#1725 (cherry picked from commit 0ede19a)
This commit adds JDK matrix Buildkite pipelines for Windows 2022, 2019 and 2016. It also makes the groups easier to read (on both Linux and Windows pipelines) by removing the os-jdk prefix from the job labels. `testDLQWriterFlusherRemovesExpiredSegmentWhenCurrentHeadSegmentIsEmpty` fails on Windows Buildkite agents and it's a test issue tracked in #15562. Relates: - #15539 - elastic/ingest-dev#1725 (cherry picked from commit 0ede19a) Co-authored-by: Dimitrios Liappis <[email protected]>
This commit adds JDK matrix Buildkite pipelines for Windows 2022, 2019 and 2016. It also makes the groups easier to read (on both Linux and Windows pipelines) by removing the os-jdk prefix from the job labels. `testDLQWriterFlusherRemovesExpiredSegmentWhenCurrentHeadSegmentIsEmpty` fails on Windows Buildkite agents and it's a test issue tracked in #15562. Relates: - #15539 - elastic/ingest-dev#1725 (cherry picked from commit 0ede19a) Co-authored-by: Dimitrios Liappis <[email protected]>
This commit adds JDK matrix Buildkite pipelines for Windows 2022, 2019 and 2016. It also makes the groups easier to read (on both Linux and Windows pipelines) by removing the os-jdk prefix from the job labels. `testDLQWriterFlusherRemovesExpiredSegmentWhenCurrentHeadSegmentIsEmpty` fails on Windows Buildkite agents and it's a test issue tracked in #15562. Relates: - #15539 - elastic/ingest-dev#1725 (cherry picked from commit 0ede19a) Co-authored-by: Dimitrios Liappis <[email protected]>
Release notes
[rn:skip]
What does this PR do?
This commit adds JDK matrix Buildkite pipelines for Windows 2022, 2019 and 2016.
It also makes the groups easier to read (on both Linux and Windows pipelines) by removing the os-jdk prefix from the job labels.
testDLQWriterFlusherRemovesExpiredSegmentWhenCurrentHeadSegmentIsEmpty
fails on Windows Buildkite agents and it's a test issue tracked in #15562.Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration files (and/or docker env variables)Linux improved group views (link):
Screenshot
Windows run (link):
This run demonstrates two failures (Windows 2022 + 2019) due to #15562 , as well a success (Windows 2019).
Screenshot
Note that we also collect archived build artifacts to assist with troubleshooting:
Screenshot
How to test this PR locally
Just kick off a build using https://buildkite.com/elastic/logstash-windows-jdk-matrix-pipeline#new and defining this PR i.e.
pull/15563/merge
in thebranch
field.Related issues
testDLQWriterFlusherRemovesExpiredSegmentWhenCurrentHeadSegmentIsEmpty
fails on Windows 2022/2019 using Buildkite #15562